BewareMyPower commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832371254
########## File path: pulsar-client-cpp/lib/ChunkMessageIdImpl.h ########## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <cstdint> +#include <memory> +#include "MessageIdImpl.h" + +namespace pulsar { + +class MessageIdImpl; + +class ChunkMessageIdImpl : public MessageIdImpl, public std::enable_shared_from_this<ChunkMessageIdImpl> { + public: + ChunkMessageIdImpl(const MessageIdImpl& firstChunkMsgId, const MessageIdImpl& lastChunkMsgId) + : MessageIdImpl(lastChunkMsgId), firstChunkMsgId_(firstChunkMsgId) {} + + const MessageIdImpl& getFirstChunkMessageIdImpl() { return firstChunkMsgId_; } Review comment: ```suggestion const MessageIdImpl& getFirstChunkMessageIdImpl() const { return firstChunkMsgId_; } ``` ########## File path: pulsar-client-cpp/lib/Commands.cc ########## @@ -469,6 +469,19 @@ SharedBuffer Commands::newSeek(uint64_t consumerId, uint64_t requestId, const Me return writeMessageWithSize(cmd); } +SharedBuffer Commands::newSeek(uint64_t consumerId, uint64_t requestId, int64_t ledgerId, int64_t entryId) { + BaseCommand cmd; + cmd.set_type(BaseCommand::SEEK); + CommandSeek* commandSeek = cmd.mutable_seek(); + commandSeek->set_consumer_id(consumerId); + commandSeek->set_request_id(requestId); + + MessageIdData& messageIdData = *commandSeek->mutable_message_id(); + messageIdData.set_ledgerid(ledgerId); + messageIdData.set_entryid(entryId); + return writeMessageWithSize(cmd); +} Review comment: After you add this new overload, I think the previous `newSeek` implementation can be simplified. ```c++ SharedBuffer Commands::newSeek(uint64_t consumerId, uint64_t requestId, const MessageId& messageId) { return newSeek(consumerId, requestId, messageId.ledgerId(), messageId.entryId()); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
