RobertIndie commented on PR #16797: URL: https://github.com/apache/pulsar/pull/16797#issuecomment-1203541387
> In short, I think there is no need to check the chunk msg size. You're right. If we need to give the client the responsibility to check the correctness of the metadata or the correctness of the client's implementation, then many things need to be checked. > I guess the original code of `msgMetadata.getChunkId() >= msgMetadata.getTotalChunkMsgSize()` might be `msgMetadata.getChunkId() >= msgMetadata.getNumChunksFromMsg()` to check if the chunk id is invalid. I think we can change this PR by removing this validation to not confuse other developers. This validation must be false. It's better to remove such redundant validation. @Gleiphir2769 @BewareMyPower -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
