Gleiphir2769 commented on PR #16797: URL: https://github.com/apache/pulsar/pull/16797#issuecomment-1204692997
> In short, I think there is no need to check the chunk msg size. You are right, the check for totalchunk is no need. > This validation must be false. It's better to remove such redundant validation. I agree, it's better to remove it because even in original intention of original code, `msgMetadata.getChunkId() >= msgMetadata.getNumChunksFromMsg()` is also redundant. > We should also change the log in the if block as well. This reminds me, thanks. I will do this change. @BewareMyPower @RobertIndie -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
