BewareMyPower commented on PR #16797: URL: https://github.com/apache/pulsar/pull/16797#issuecomment-1203580501
I agree, we can simply remove this line. Actually, when I migrated the chunking feature into C++ client, I only checked the chunk id and the current number of chunks. Maybe this implementation would be better https://github.com/apache/pulsar/blob/68e454544d45734129e67ab3032eae3e40ff664c/pulsar-client-cpp/lib/ConsumerImpl.h#L240 https://github.com/apache/pulsar/blob/68e454544d45734129e67ab3032eae3e40ff664c/pulsar-client-cpp/lib/ConsumerImpl.h#L262-L264 https://github.com/apache/pulsar/blob/68e454544d45734129e67ab3032eae3e40ff664c/pulsar-client-cpp/lib/ConsumerImpl.cc#L354-L355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
