tisonkun commented on code in PR #17148:
URL: https://github.com/apache/pulsar/pull/17148#discussion_r949711928
##########
tests/docker-images/latest-version-image/pom.xml:
##########
@@ -101,35 +108,31 @@
</executions>
</plugin>
<plugin>
- <groupId>com.spotify</groupId>
- <artifactId>dockerfile-maven-plugin</artifactId>
- <version>${dockerfile-maven.version}</version>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
<executions>
<execution>
<id>default</id>
<phase>package</phase>
<goals>
<goal>build</goal>
Review Comment:
Please read [the document of
`docker-maven-plugin`](https://dmp.fabric8.io/#build-configuration). There's no
`tag` goal. To perform tagging, this patch shows the correct way:
https://github.com/apache/pulsar/blob/5037bb1c59c6818772c845ea7909d32682dd6085/tests/docker-images/latest-version-image/pom.xml#L126-L129
##########
tests/docker-images/java-test-image/pom.xml:
##########
@@ -135,39 +139,31 @@
</executions>
</plugin>
<plugin>
- <groupId>com.spotify</groupId>
- <artifactId>dockerfile-maven-plugin</artifactId>
- <version>${dockerfile-maven.version}</version>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
<executions>
<execution>
<id>default</id>
<phase>package</phase>
<goals>
<goal>build</goal>
Review Comment:
See https://github.com/apache/pulsar/pull/17148#discussion_r949711928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
