tisonkun commented on code in PR #17148:
URL: https://github.com/apache/pulsar/pull/17148#discussion_r950930618


##########
docker/pulsar/pom.xml:
##########
@@ -103,57 +107,71 @@
             </executions>
           </plugin>
           <plugin>
-            <groupId>com.spotify</groupId>
-            <artifactId>dockerfile-maven-plugin</artifactId>
-            <version>${dockerfile-maven.version}</version>
+            <groupId>io.fabric8</groupId>
+            <artifactId>docker-maven-plugin</artifactId>

Review Comment:
   CI failed with:
   
   ```
   Error:  Failed to execute goal io.fabric8:docker-maven-plugin:0.40.2:build 
(default) on project pulsar-docker-image: No image 'busybox' found and pull 
policy 'Never' is set. Please chose another pull policy or pull the image 
yourself) -> [Help 1]
   ```
   
   After a few investigation, I notice that the original 
`dockerfile.build.pullNewerImage` means `Updates base images automatically`. So 
if we configure `imagePullPolicy` as `IfNotPresent` (default), we just retain 
the behaviour.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to