tisonkun commented on code in PR #17148:
URL: https://github.com/apache/pulsar/pull/17148#discussion_r949713557
##########
docker/pulsar/pom.xml:
##########
@@ -103,57 +107,71 @@
</executions>
</plugin>
<plugin>
- <groupId>com.spotify</groupId>
- <artifactId>dockerfile-maven-plugin</artifactId>
- <version>${dockerfile-maven.version}</version>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
<executions>
<execution>
<id>default</id>
+ <phase>package</phase>
<goals>
<goal>build</goal>
</goals>
- </execution>
- <execution>
- <id>add-no-repo-and-version</id>
- <goals>
- <goal>tag</goal>
- </goals>
<configuration>
- <repository>pulsar</repository>
- <tag>${project.version}</tag>
+ <images>
+ <image>
+ <name>${docker.organization}/pulsar</name>
+ <build>
+ <contextDir>${project.basedir}</contextDir>
+ <tags>
+ <tag>latest</tag>
+ <tag>${project.version}</tag>
+ </tags>
+ </build>
+ </image>
+ </images>
</configuration>
</execution>
<execution>
- <id>add-no-repo-and-latest</id>
+ <id>push-latest</id>
Review Comment:
This seems reasonable. I'm glad to integrate with this change if @sijie
@merlimat @codelipenghui can confirm.
I found the original logic was introduced at
https://github.com/apache/pulsar/pull/4705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
