asafm commented on code in PR #17041:
URL: https://github.com/apache/pulsar/pull/17041#discussion_r962306304
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java:
##########
@@ -126,6 +131,9 @@ public CompletableFuture<Boolean> asyncReload(String key,
Boolean oldValue,
}
}
});
+
+ this.metadataStoreName = poolName + "-" + ID.getAndIncrement();
Review Comment:
I guess my question is this: If we have 2 types of metadata stores, one
instance of each, why not have the metadata store name be just the type:
"metadata-store" and "configuration-metadata-store" - why keep regenerating the
name using an auto incremented ID?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
