asafm commented on code in PR #17041:
URL: https://github.com/apache/pulsar/pull/17041#discussion_r962308022
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java:
##########
@@ -1522,6 +1524,81 @@ public void testSplitTopicAndPartitionLabel() throws
Exception {
consumer2.close();
}
+
+ @Test
+ public void testMetadataStoreStats() throws Exception {
Review Comment:
The file `PrometheusMetricsTest.java` is already very large.
I believe making it was a mistake, since creating a class that test, so many
things leads to huge unreadable class.
I recommend moving those tests to `MetadataStoreStatsTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
