Jason918 commented on code in PR #17164:
URL: https://github.com/apache/pulsar/pull/17164#discussion_r969080552
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -365,6 +367,48 @@ public void operationFailed(MetaStoreException e) {
return updateCursorPropertiesResult;
}
+ @Override
+ public CompletableFuture<Void> setCursorProperties(Map<String, String>
cursorProperties) {
+ Map<String, String> newProperties =
+ cursorProperties == null ? new HashMap<>() : new
HashMap<>(cursorProperties);
+ long stamp = cursorPropertiesUpdateLock.writeLock();
Review Comment:
@coderzc I think timeout is not the best option here.
You can take a look at `MetadataCacheImpl#readModifyUpdateOrCreate`. It
implements atomic update on metadata cache and supports concurrent writes. The
main idea is update metadata store with version check and retry the op if there
is concurrent updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
