Jason918 commented on code in PR #17164:
URL: https://github.com/apache/pulsar/pull/17164#discussion_r970418380
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -324,24 +326,25 @@ public Map<String, String> getCursorProperties() {
return cursorProperties;
}
- @Override
- public CompletableFuture<Void> setCursorProperties(Map<String, String>
cursorProperties) {
+ private CompletableFuture<Void> asyncReadAndUpdateCursorProperties(
+ final Function<Map<String, String>, Map<String, String>>
updateFunction) {
CompletableFuture<Void> updateCursorPropertiesResult = new
CompletableFuture<>();
ledger.getStore().asyncGetCursorInfo(ledger.getName(), name, new
MetaStoreCallback<>() {
Review Comment:
> Instead, we can only update the local properties cache if we get a
BadVersion exception
Will this introduce inconsistency between broker memory state and zookeeper
storage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
