Jason918 commented on code in PR #17164:
URL: https://github.com/apache/pulsar/pull/17164#discussion_r973530502
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -175,6 +177,8 @@ public class ManagedCursorImpl implements ManagedCursor {
// Stat of the cursor z-node
private volatile Stat cursorLedgerStat;
+ private volatile ManagedCursorInfo managedCursorInfo;
Review Comment:
> Also, I think one more get operation might be fine since this feature
isn't used very often.
> But when we add this variable it will affect other logic and introduce the
risk of data inconsistency.
@mattisonchao
This PR have this "get" at first. It's removed under Penghui's suggestion.
After check the usage of `cursorLedgerStat`, I think it's ok to drop the
"get" op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
