codelipenghui commented on code in PR #17816:
URL: https://github.com/apache/pulsar/pull/17816#discussion_r981153792
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java:
##########
@@ -192,6 +192,7 @@ public void findEntryFailed(ManagedLedgerException
exception, Optional<Position>
log.warn("[{}][{}] read failed from ledger at position:{} : {}",
topicName, subName, failedReadPosition,
exception.getMessage());
findEntryComplete(failedReadPosition.get(), ctx);
+ return;
Review Comment:
> The findEntryComplete method will change the expirationCheckInProgress to
FALSE. see line182
Please see line 107. If we return here, the expirationCheckInProgress=true,
we will not have a chance to call `findEntryComplete` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
