codelipenghui commented on code in PR #17816:
URL: https://github.com/apache/pulsar/pull/17816#discussion_r982980348
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java:
##########
@@ -192,6 +192,7 @@ public void findEntryFailed(ManagedLedgerException
exception, Optional<Position>
log.warn("[{}][{}] read failed from ledger at position:{} : {}",
topicName, subName, failedReadPosition,
exception.getMessage());
findEntryComplete(failedReadPosition.get(), ctx);
Review Comment:
@AnonHxy If we have completed the find entry task either succeeded or
failed, we change `expirationCheckInProgress` to false, no? Otherwise, it looks
like we will set `expirationCheckInProgress=true` before starting to find the
entry, but the findEntryComplete and findEntryFailed can't ensure the
`expirationCheckInProgress` change to false finally, it sounds confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
