AnonHxy commented on code in PR #17816:
URL: https://github.com/apache/pulsar/pull/17816#discussion_r982580764
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java:
##########
@@ -192,6 +192,7 @@ public void findEntryFailed(ManagedLedgerException
exception, Optional<Position>
log.warn("[{}][{}] read failed from ledger at position:{} : {}",
topicName, subName, failedReadPosition,
exception.getMessage());
findEntryComplete(failedReadPosition.get(), ctx);
Review Comment:
It seems that here we just want to handle `findEntryFailed` like
`findEntryComplete` if `autoSkipNonRecoverableData=true`. And
`findEntryComplete` will change `expirationCheckInProgress` to false. So this
change looks reasonable I think @Pomelongan @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
