merlimat commented on a change in pull request #4247: [WIP] PIP-36: Support set
message size in broker.conf
URL: https://github.com/apache/pulsar/pull/4247#discussion_r282577180
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -489,6 +489,11 @@
+ " Using a value of 0, is disabling
maxConsumersPerSubscription-limit check.")
private int maxConsumersPerSubscription = 0;
+ @FieldContext(category = CATEGORY_SERVER, doc = "The size of messages.")
+ private int maxMessageSize = 5 * 1024 * 1024;
+
+ private int maxFrameSize = 5242880;
Review comment:
Having 2 settings, which are ultimately strongly related, could be confusing
to users. I think the max message size with some padding for headers would be
easier in general.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
