merlimat commented on a change in pull request #4247: [WIP] PIP-36: Support set
message size in broker.conf
URL: https://github.com/apache/pulsar/pull/4247#discussion_r282579860
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java
##########
@@ -218,7 +218,8 @@ private void completeConnect() {
// partitions metadata lookups
state = State.ProxyLookupRequests;
lookupProxyHandler = new LookupProxyHandler(service, this);
-
ctx.writeAndFlush(Commands.newConnected(protocolVersionToAdvertise));
+ ctx.writeAndFlush(
+ Commands.newConnected(protocolVersionToAdvertise,
service.getConfiguration().getMaxMessagesSize()));
Review comment:
Proxy should also take into consideration what's the min between proxy and
broker.
Eg: if proxy has 5MB and broker has 1MB, proxy should downgrade itself to 1MB
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
