merlimat commented on a change in pull request #4247: [WIP] PIP-36: Support set
message size in broker.conf
URL: https://github.com/apache/pulsar/pull/4247#discussion_r282578963
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -213,6 +213,7 @@ message CommandConnect {
message CommandConnected {
required string server_version = 1;
optional int32 protocol_version = 2 [default = 0];
+ optional int32 max_message_size = 3 [default = 5242880];
Review comment:
For this kind of numbers, I'd leave the default empty and let the
client/broker assume the 5MB default.
In particular, if the default is in Java code, we can put in a constant
shared between client and broker and keep it in a single place
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
