BewareMyPower commented on code in PR #54:
URL: https://github.com/apache/pulsar-client-cpp/pull/54#discussion_r1000439489
##########
lib/ConsumerImpl.cc:
##########
@@ -990,20 +1002,25 @@ void ConsumerImpl::negativeAcknowledge(const MessageId&
messageId) {
void ConsumerImpl::disconnectConsumer() {
LOG_INFO("Broker notification of Closed consumer: " << consumerId_);
- Lock lock(mutex_);
- connection_.reset();
- lock.unlock();
+ resetCnx();
scheduleReconnection(get_shared_this_ptr());
}
-void ConsumerImpl::closeAsync(ResultCallback callback) {
- // Keep a reference to ensure object is kept alive
- ConsumerImplPtr ptr = get_shared_this_ptr();
+void ConsumerImpl::closeAsync(ResultCallback originalCallback) {
+ auto callback = [this, originalCallback](Result result) {
+ shutdown();
Review Comment:
@RobertIndie Yes, this PR just follows what Java client does.
https://github.com/apache/pulsar/blob/cbf5cf58196b05a35b31385c6a42098c598c9b33/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L413-L422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
