merlimat commented on code in PR #54:
URL: https://github.com/apache/pulsar-client-cpp/pull/54#discussion_r1000727982
##########
lib/HandlerBase.h:
##########
@@ -44,11 +44,9 @@ class HandlerBase {
void start();
- /*
- * get method for derived class to access weak ptr to connection so that
they
- * have to check if they can get a shared_ptr out of it or not
- */
- ClientConnectionWeakPtr getCnx() const { return connection_; }
+ ClientConnectionWeakPtr getCnx() const;
Review Comment:
nit: for later, we could return the `shared_ptr` here, already locked inside
the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
