BewareMyPower commented on PR #54: URL: https://github.com/apache/pulsar-client-cpp/pull/54#issuecomment-1285297178
@merlimat @shibd @RobertIndie Thanks for your reviews. Now I have removed the (`ClientImplWeakPtr` -> `ClientImpl&`) changes and fixed the newly discovered cyclic references (`testDestructor` will fail without the fix), PTAL again. I changed the milestone to 3.0.0, could you include this PR in the next candidate? @merlimat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
