BewareMyPower opened a new pull request, #18392: URL: https://github.com/apache/pulsar/pull/18392
### Motivation There are a lot of duplicated code in PersistentAcknowledgmentsGroupingTracker caused by the check for whether the ACK receipt is supported. The only difference is that the read write lock will be used and then `currentIndividualAckFuture` or `currentCumulativeAckFuture` will be returned. In addition, the `validationError` argument in `newMessageAckCommandAndWrite` is never used. ### Modifications Move the `isAckReceiptEnabled` into `ConsumerImpl` and add two methods `acquireReadLock`/`acquireWriteLock` to acquire the read or write lock if ACK receipt is enabled. Remove the `validationError` argument. ### Verifying this change - [x] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as `ConsumerRedeliveryTest`. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: https://github.com/BewareMyPower/pulsar/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
