BewareMyPower commented on code in PR #18392:
URL: https://github.com/apache/pulsar/pull/18392#discussion_r1019034147


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java:
##########
@@ -57,6 +58,12 @@
 @Slf4j
 public class PersistentAcknowledgmentsGroupingTracker implements 
AcknowledgmentsGroupingTracker {
 
+    private static final TimedCompletableFuture<Void> COMPLETED_FUTURE = new 
TimedCompletableFuture<>();

Review Comment:
   Sure. But could you explain more about why a static CompletableFuture cannot 
be used?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to