congbobo184 commented on code in PR #18392:
URL: https://github.com/apache/pulsar/pull/18392#discussion_r1017438531
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java:
##########
@@ -66,8 +67,8 @@ public class PersistentAcknowledgmentsGroupingTracker
implements Acknowledgments
private final long acknowledgementGroupTimeMicros;
- private volatile TimedCompletableFuture<Void> currentIndividualAckFuture;
- private volatile TimedCompletableFuture<Void> currentCumulativeAckFuture;
+ private volatile CompletableFuture<Void> currentIndividualAckFuture;
+ private volatile CompletableFuture<Void> currentCumulativeAckFuture;
Review Comment:
can we return a completed singleton of `TimedCompletableFuture.class` when
ackReciept is disabled? and don't change this type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
