onobc commented on PR #18646: URL: https://github.com/apache/pulsar/pull/18646#issuecomment-1328540621
Hi @codelipenghui > @onobc Have you tried if the change works Yes, I have verified that when I use the `2.11.0-SNAPSHOT` shaded lib (built locally) and include the `netty-resolver-dns-native-macos` in my app the WARN goes away. When I remove the `netty-resolver-dns-native-macos` lib the WARN comes back. > IMO, we should add [netty-resolver-dns-native-macos](https://mvnrepository.com/artifact/io.netty/netty-resolver-dns-native-macos/4.1.85.Final) to the Pulsar Client dependencies(not your project dependencies) due to Pulsar will shade all the netty libs when building the client shaded jar. This is a good point and a good thing for me to try. I did not pursue this path originally as I did not think that would work as the Mac DNS provider would always be on the classpath. However, I believe that Netty uses the os and arch to figure out which provider to actually load. IOW - only when you are running on M1 would this DNS provider actually be used. I will verify that is in fact true and then try to include it in client deps and shade it. That would get rid of the partial shading as well as prevent users from having to add this manually themselves. I should be able to take a look w/in the next 24hrs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
