onobc commented on PR #18646: URL: https://github.com/apache/pulsar/pull/18646#issuecomment-1329226213
> > However, this does NOT work for Pulsar when using the pulsar-client-all shared jar because it attempts to load the M1 version w/ the shaded prefix (org.apache.pulsar.shade.io.netty.resolver.dns.macos.MacOSDnsServerAddressStreamProvider rather than io.netty.resolver.dns.macos.MacOSDnsServerAddressStreamProvider). > > In Pulsar, there's a custom solution to deal with relocating native Netty library files. There are scripts https://github.com/apache/pulsar/blob/master/src/rename-netty-native-libs.sh (bash) and https://github.com/apache/pulsar/blob/master/src/rename-netty-native-libs.cmd (powershell, when building on windows). > > These scripts are used in pulsar-client-all/pom.xml and pulsar-client-shaded/pom.xml . > > https://github.com/apache/pulsar/blob/8b404d4ce14a1a10bd7569826754800f2cab5b0b/pulsar-client-all/pom.xml#L378-L399 > > Perhaps we could modify rename-netty-native-libs.sh and rename-netty-native-libs.cmd to also handle netty-resolver-dns-native-macos ? Thanks for that info @lhotari - I definitely missed that detail. I will take a look at this. It will also blend well w/ @codelipenghui suggestion of shading the native mac os lib rather than unshading the whole dns package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
