Jennifer88huang commented on a change in pull request #4367:
[document][swagger]Update topics rest api document
URL: https://github.com/apache/pulsar/pull/4367#discussion_r287558903
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -388,9 +537,23 @@ public void
expireMessagesForAllSubscriptions(@PathParam("tenant") String tenant
@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have
admin permission"),
@ApiResponse(code = 404, message = "Topic/Subscription does not
exist"),
@ApiResponse(code = 405, message = "Not supported for partitioned
topics") })
- public void createSubscription(@PathParam("tenant") String tenant,
@PathParam("namespace") String namespace,
- @PathParam("topic") @Encoded String topic,
@PathParam("subscriptionName") String encodedSubName,
- @QueryParam("authoritative") @DefaultValue("false") boolean
authoritative, MessageIdImpl messageId, @QueryParam("replicated") boolean
replicated) {
+ public void createSubscription(
+ @ApiParam(value = "Specify the tenant to which this topic
belongs", required = true)
+ @PathParam("tenant") String tenant,
+ @ApiParam(value = "Specify the namespace to which this topic
belongs", required = true)
+ @PathParam("namespace") String namespace,
+ @ApiParam(value = "Specifies topic name", required = true)
+ @PathParam("topic") @Encoded String topic,
+ @ApiParam(value = "Subscription to create position on", required =
true)
+ @PathParam("subscriptionName") String encodedSubName,
+ @ApiParam(value = "messageId where to create the subscription. " +
+ "It can be either 'latest', 'earliest' or
(ledgerId:entryId)",
Review comment:
```suggestion
"It can be 'latest', 'earliest' or (ledgerId:entryId)",
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
