Jennifer88huang commented on a change in pull request #4367:
[document][swagger]Update topics rest api document
URL: https://github.com/apache/pulsar/pull/4367#discussion_r287558869
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -361,9 +494,18 @@ public void skipMessages(@PathParam("tenant") String
tenant, @PathParam("namespa
@ApiOperation(value = "Expire messages on a topic subscription.")
@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have
admin permission"),
@ApiResponse(code = 404, message = "Topic or subscription does not
exist") })
- public void expireTopicMessages(@PathParam("tenant") String tenant,
@PathParam("namespace") String namespace,
- @PathParam("topic") @Encoded String encodedTopic,
@PathParam("subName") String encodedSubName,
+ public void expireTopicMessages(
+ @ApiParam(value = "Specify the tenant to which this topic
belongs", required = true)
+ @PathParam("tenant") String tenant,
+ @ApiParam(value = "Specify the namespace to which this topic
belongs", required = true)
+ @PathParam("namespace") String namespace,
+ @ApiParam(value = "Specifies topic name", required = true)
+ @PathParam("topic") @Encoded String encodedTopic,
+ @ApiParam(value = "Subscription to be expire messages on")
Review comment:
we can re-write this sentence to make it more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
