Jennifer88huang commented on a change in pull request #4367:
[document][swagger]Update topics rest api document
URL: https://github.com/apache/pulsar/pull/4367#discussion_r291825139
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -462,26 +802,49 @@ public MessageId terminate(@PathParam("tenant") String
tenant, @PathParam("names
@PUT
@Path("/{tenant}/{namespace}/{topic}/compaction")
@ApiOperation(value = "Trigger a compaction operation on a topic.")
- @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have
admin permission"),
- @ApiResponse(code = 405, message = "Operation not
allowed on persistent topic"),
- @ApiResponse(code = 404, message = "Topic does not
exist"),
- @ApiResponse(code = 409, message = "Compaction
already running")})
- public void compact(@PathParam("tenant") String tenant,
- @PathParam("namespace") String namespace,
@PathParam("topic") @Encoded String encodedTopic,
- @QueryParam("authoritative") @DefaultValue("false")
boolean authoritative) {
+ @ApiResponses(value = {
+ @ApiResponse(code = 401, message = "Don't have permission to
administrate resources on this tenant or" +
+ "subscriber is not authorized to access this operation"),
+ @ApiResponse(code = 403, message = "Don't have admin permission"),
+ @ApiResponse(code = 404, message = "Topic does not exist"),
+ @ApiResponse(code = 405, message = "Operation not allowed on
persistent topic"),
Review comment:
```suggestion
@ApiResponse(code = 405, message = "Operation is not allowed on
the persistent topic"),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
