codelipenghui commented on code in PR #19256:
URL: https://github.com/apache/pulsar/pull/19256#discussion_r1073509207
##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java:
##########
@@ -803,6 +803,12 @@ public class ProxyConfiguration implements
PulsarConfiguration {
)
private boolean webSocketServiceEnabled = false;
+ @FieldContext(
+ category = CATEGORY_WEBSOCKET,
+ doc = "Interval of time to sending the ping to keep alive in
WebSocket proxy. "
+ + "This value greater than 0 means enabled")
+ private int webSocketPingDurationSeconds = -1;
Review Comment:
It is better to use `webSocketKeepAliveIntervalSeconds` to make it
consistent with the existing name `keepAliveIntervalSeconds`
And we should also add `keepAliveIntervalSeconds` to `websocket.conf`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
