poorbarcode commented on code in PR #19256:
URL: https://github.com/apache/pulsar/pull/19256#discussion_r1082050185
##########
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java:
##########
@@ -192,18 +191,15 @@ private void closePingFuture() {
@Override
public void onWebSocketConnect(Session session) {
super.onWebSocketConnect(session);
- WebSocketProxyConfiguration webSocketProxyConfig =
service.getWebSocketProxyConfig();
- if (webSocketProxyConfig != null) {
- int webSocketPingDurationSeconds =
webSocketProxyConfig.getWebSocketPingDurationSeconds();
Review Comment:
> No. My changes don't break the tests of
https://github.com/apache/pulsar/pull/19203.
Ah, yes. you are right. The configuration that acts on
`WebSocketProxyConfiguration` is copied to `ServiceConfiguration`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
