poorbarcode commented on code in PR #19256:
URL: https://github.com/apache/pulsar/pull/19256#discussion_r1081437289
##########
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java:
##########
@@ -192,18 +191,15 @@ private void closePingFuture() {
@Override
public void onWebSocketConnect(Session session) {
super.onWebSocketConnect(session);
- WebSocketProxyConfiguration webSocketProxyConfig =
service.getWebSocketProxyConfig();
- if (webSocketProxyConfig != null) {
- int webSocketPingDurationSeconds =
webSocketProxyConfig.getWebSocketPingDurationSeconds();
Review Comment:
I see.
> Should we also should edit the test added in
https://github.com/apache/pulsar/pull/19203?
And this comment ^_^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
