michaeljmarshall opened a new pull request, #19282:
URL: https://github.com/apache/pulsar/pull/19282

   ### Motivation
   
   We use the result of `TokenAuthenticationState#getAuthDataSource` to pass to 
the `AuthorizationProvider`. For custom implementations, it is important that 
this information is up to date.
   
   The `TokenAuthenticationState` field `AuthenticationDataSource` is set on 
initialization and never again. Given that tokens can be refreshed, we should 
update the field `TokenAuthenticationState#authenticationDataSource` when the 
`authenticate` method is called.
   
   ### Modifications
   
   * Update the `authenticationDataSource` when `authenticate` is called.
   
   ### Verifying this change
   
   A new test is added to cover this change.
   
   ### Does this pull request potentially affect one of the following parts:
   
   This change will  only affect third party `AuthorizationProvider` 
implementations. It's possible that it could break their integration, though 
unlikely. Note that we update the `authRole` when `authenticate` is called.
   
   ### Documentation
   
   - [x] `doc-not-needed` 
   
   We do not document this kind of internal behavior anywhere.
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/michaeljmarshall/pulsar/pull/15


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to