lhotari commented on code in PR #19282:
URL: https://github.com/apache/pulsar/pull/19282#discussion_r1081623676
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java:
##########
@@ -375,6 +383,7 @@ public String getAuthRole() throws AuthenticationException {
public AuthData authenticate(AuthData authData) throws
AuthenticationException {
String token = new String(authData.getBytes(), UTF_8);
checkExpiration(token);
+ this.authenticationDataSource = new
AuthenticationDataCommand(token, remoteAddress, sslSession);
Review Comment:
Is there any thread safety concerns here? would it make sense to make
authenticationDataSource field `volatile`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
