michaeljmarshall commented on code in PR #19282:
URL: https://github.com/apache/pulsar/pull/19282#discussion_r1081673239
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java:
##########
@@ -375,6 +383,7 @@ public String getAuthRole() throws AuthenticationException {
public AuthData authenticate(AuthData authData) throws
AuthenticationException {
String token = new String(authData.getBytes(), UTF_8);
checkExpiration(token);
+ this.authenticationDataSource = new
AuthenticationDataCommand(token, remoteAddress, sslSession);
Review Comment:
Good question. The current usage of this field in the pulsar code base is
all from netty event loops, so I don't think that is needed. Similarly, the
`jwt` and the `expiration` are not `volatile`. I see that `expiration` is
called from another thread, so that one might be an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
