andrasbeni commented on code in PR #19208:
URL: https://github.com/apache/pulsar/pull/19208#discussion_r1081205419
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java:
##########
@@ -45,19 +62,50 @@ public static MetadataStoreExtended createExtended(String
metadataURL, MetadataS
private static MetadataStore newInstance(String metadataURL,
MetadataStoreConfig metadataStoreConfig,
boolean enableSessionWatcher)
throws MetadataStoreException {
+ MetadataStoreProvider provider = findProvider(metadataURL);
+ if (provider != null) {
+ return provider.create(metadataURL, metadataStoreConfig,
enableSessionWatcher);
+ }
+ return new ZKMetadataStore(metadataURL, metadataStoreConfig,
enableSessionWatcher);
+ }
+
+ static void loadProviders() {
+ String factoryClasses =
System.getProperty(METADATASTORE_PROVIDERS_PROPERTY);
Review Comment:
@asafm
1. Based on the call hierarchy of `newInstance`, these are some of those
tools/services:
```
CompactorTool.main(String[]) (org.apache.pulsar.compaction)
ManagedLedgerWriter.main(String[]) (org.apache.pulsar.testclient)
ProxyServiceStarter.main(String[]) (org.apache.pulsar.proxy.server)
PulsarClusterMetadataSetup.main(String[]) (org.apache.pulsar)
PulsarClusterMetadataTeardown.main(String[]) (org.apache.pulsar)
PulsarInitialNamespaceSetup.doMain(String[]) (org.apache.pulsar)
PulsarStandaloneStarter.main(String[]) (org.apache.pulsar)
PulsarTransactionCoordinatorMetadataSetup.main(String[]) (org.apache.pulsar)
WebSocketServiceStarter.main(String[]) (org.apache.pulsar.websocket.service)
```
2. Pulsar implements some BK interfaces to be able to plug its
implementations as providers in the BK client and bookie. see
https://github.com/apache/pulsar/blob/master/bin/pulsar#L353-L359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
