asafm commented on PR #19208: URL: https://github.com/apache/pulsar/pull/19208#issuecomment-1397546362
Sorry about this. I think my [comment](https://github.com/apache/pulsar/pull/19208#discussion_r1081486335) thread has been hiding as resolved, so I'm resurfacing it if that's ok @andrasbeni ```java String factoryClasses = System.getProperty(METADATASTORE_PROVIDERS_PROPERTY); ``` 1. @andrasbeni The only tool I see here is CompactorTool, the rest are just plain Pulsar services that have access to Pulsar config. The Comparator tool itself has an argument `@Parameter(names = {"-c", "--broker-conf"}, description = "Configuration file for Broker")` so it also has access to the configuration file. So based on that, it seems that we can use the Pulsar configuration for those provider classes, no? 2. That one is a bit odd. If Pulsar is creating the BK client, why not provide the Client Metadata driver through the BK client itself? Why go through a System property to statically initialize? It may make sense inside BK itself. Maybe @hangc0276 knows. We can also call it when Pulsar initializes, as it has a method. Based on (1) and (2), I don't understand why we can't use Pulsar configuration for that config @andrasbeni Last question, @andrasbeni: does Pulsar have a mechanism that, based on an ENV variable or System property, sets a property in the configuration (like an override)? So you can define it in the pulsar configuration and use the technique you used to set it via a system property, making it less intrusive, less static code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
