thetumbled commented on code in PR #19201:
URL: https://github.com/apache/pulsar/pull/19201#discussion_r1089918067
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/TransactionMetadataStoreService.java:
##########
@@ -133,54 +133,56 @@ public CompletableFuture<Void>
handleTcClientConnect(TransactionCoordinatorID tc
return;
}
- openTransactionMetadataStore(tcId).thenAccept((store)
-> internalPinnedExecutor.execute(() -> {
+ openTransactionMetadataStore(tcId).thenAccept((store)
-> {
stores.put(tcId, store);
LOG.info("Added new transaction meta store {}",
tcId);
- long endTime = System.currentTimeMillis() +
HANDLE_PENDING_CONNECT_TIME_OUT;
- while (true) {
- // prevent thread in a busy loop.
- if (System.currentTimeMillis() < endTime) {
- CompletableFuture<Void> future =
deque.poll();
- if (future != null) {
- // complete queue request future
- future.complete(null);
+ internalPinnedExecutor.execute(() -> {
+ long endTime = System.currentTimeMillis() +
HANDLE_PENDING_CONNECT_TIME_OUT;
+ while (true) {
+ // prevent thread in a busy loop.
+ if (System.currentTimeMillis() < endTime) {
+ CompletableFuture<Void> future =
deque.poll();
+ if (future != null) {
+ // complete queue request future
+ future.complete(null);
+ } else {
+ break;
+ }
} else {
+ deque.clear();
break;
}
- } else {
- deque.clear();
- break;
}
- }
- completableFuture.complete(null);
- tcLoadSemaphore.release();
- })).exceptionally(e -> {
+ completableFuture.complete(null);
Review Comment:
The completableFuture return by `openTransactionMetadataStore(tcId)` is
completed by following code in thread
`MLTransactionMetadataStore#internalPinnedExecutor`.
```
**completableFuture.complete(MLTransactionMetadataStore.this);**
recoverTracker.handleCommittingAndAbortingTransaction();
```
Once the completableFuture is completed, `stores.put` will be executed in
another thread `TransactionMetadataStoreService#internalPinnedExecutor`.
```
openTransactionMetadataStore(tcId).thenAccept((store) ->
internalPinnedExecutor.execute(() -> {
stores.put(tcId, store);
```
So, we may execute `recoverTracker.handleCommittingAndAbortingTransaction()`
before execute `stores.put(tcId, store)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
