codelipenghui commented on code in PR #19201:
URL: https://github.com/apache/pulsar/pull/19201#discussion_r1089923976
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/TransactionMetadataStoreService.java:
##########
@@ -133,54 +133,56 @@ public CompletableFuture<Void>
handleTcClientConnect(TransactionCoordinatorID tc
return;
}
- openTransactionMetadataStore(tcId).thenAccept((store)
-> internalPinnedExecutor.execute(() -> {
+ openTransactionMetadataStore(tcId).thenAccept((store)
-> {
stores.put(tcId, store);
LOG.info("Added new transaction meta store {}",
tcId);
- long endTime = System.currentTimeMillis() +
HANDLE_PENDING_CONNECT_TIME_OUT;
- while (true) {
- // prevent thread in a busy loop.
- if (System.currentTimeMillis() < endTime) {
- CompletableFuture<Void> future =
deque.poll();
- if (future != null) {
- // complete queue request future
- future.complete(null);
+ internalPinnedExecutor.execute(() -> {
+ long endTime = System.currentTimeMillis() +
HANDLE_PENDING_CONNECT_TIME_OUT;
+ while (true) {
+ // prevent thread in a busy loop.
+ if (System.currentTimeMillis() < endTime) {
+ CompletableFuture<Void> future =
deque.poll();
+ if (future != null) {
+ // complete queue request future
+ future.complete(null);
+ } else {
+ break;
+ }
} else {
+ deque.clear();
break;
}
- } else {
- deque.clear();
- break;
}
- }
- completableFuture.complete(null);
- tcLoadSemaphore.release();
- })).exceptionally(e -> {
+ completableFuture.complete(null);
Review Comment:
Essentially this is a circular dependency problem.
`TransactionMetadataStoreService.handleTcClientConnect` ->
`MLTransactionMetadataStore.init` ->
`TransactionRecoverTracker.handleCommittingAndAbortingTransaction` ->
`TransactionMetadataStoreService.handleTcClientConnect`
It looks like we need to ensure some state is changed in
`TransactionMetadataStoreService` during init `MLTransactionMetadataStore`.
IMO, we should refactor this part finally to move the
`recoverTracker.handleCommittingAndAbortingTransaction();` to the
`TransactionMetadataStoreService` to decouple the mutual state dependence.
@congbobo184 @liangyepianzhou WDYT?
It's hard to understand why the map put operation should be executed out of
the internalPinnedExecutor while reading the code. This may present challenges
for future maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
