codelipenghui commented on code in PR #19201:
URL: https://github.com/apache/pulsar/pull/19201#discussion_r1090285549
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/TransactionMetadataStoreService.java:
##########
@@ -133,54 +133,56 @@ public CompletableFuture<Void>
handleTcClientConnect(TransactionCoordinatorID tc
return;
}
- openTransactionMetadataStore(tcId).thenAccept((store)
-> internalPinnedExecutor.execute(() -> {
+ openTransactionMetadataStore(tcId).thenAccept((store)
-> {
stores.put(tcId, store);
LOG.info("Added new transaction meta store {}",
tcId);
- long endTime = System.currentTimeMillis() +
HANDLE_PENDING_CONNECT_TIME_OUT;
- while (true) {
- // prevent thread in a busy loop.
- if (System.currentTimeMillis() < endTime) {
- CompletableFuture<Void> future =
deque.poll();
- if (future != null) {
- // complete queue request future
- future.complete(null);
+ internalPinnedExecutor.execute(() -> {
+ long endTime = System.currentTimeMillis() +
HANDLE_PENDING_CONNECT_TIME_OUT;
+ while (true) {
+ // prevent thread in a busy loop.
+ if (System.currentTimeMillis() < endTime) {
+ CompletableFuture<Void> future =
deque.poll();
+ if (future != null) {
+ // complete queue request future
+ future.complete(null);
+ } else {
+ break;
+ }
} else {
+ deque.clear();
break;
}
- } else {
- deque.clear();
- break;
}
- }
- completableFuture.complete(null);
- tcLoadSemaphore.release();
- })).exceptionally(e -> {
+ completableFuture.complete(null);
Review Comment:
Sorry, I haven't got the point of `openTransactionMetadataStore(tcId) then
init return the recoverTracker`, @congbobo184 Can you share the link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
