michaeljmarshall commented on code in PR #19559:
URL: https://github.com/apache/pulsar/pull/19559#discussion_r1113930242
##########
pulsar-common/src/main/java/org/apache/pulsar/policies/data/loadbalancer/LocalBrokerData.java:
##########
@@ -250,10 +250,10 @@ public String printResourceUsage() {
bandwidthOut.percentUsage());
}
- public double getMaxResourceUsageWithWeight(final double cpuWeight, final
double memoryWeight,
+ public double getMaxResourceUsageWithWeight(final double cpuWeight,
final double
directMemoryWeight, final double bandwidthInWeight,
final double
bandwidthOutWeight) {
Review Comment:
This is a breaking change to a public method users would likely call if they
have custom `LoadSheddingStrategy` implementations. If we move forward removing
the memory weight, I think we should first deprecate this method and then
remove it later.
Note that we can still change the Pulsar implementations without breaking
this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
