michaeljmarshall commented on code in PR #19559:
URL: https://github.com/apache/pulsar/pull/19559#discussion_r1115284518
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ThresholdShedder.java:
##########
@@ -168,7 +168,7 @@ private double updateAvgResourceUsage(String broker,
LocalBrokerData localBroker
brokerAvgResourceUsage.get(broker);
double resourceUsage = localBrokerData.getMaxResourceUsageWithWeight(
conf.getLoadBalancerCPUResourceWeight(),
- conf.getLoadBalancerMemoryResourceWeight(),
conf.getLoadBalancerDirectMemoryResourceWeight(),
Review Comment:
Nit: it'd be helpful to document the `LoadBalancerMemoryResourceWeight`
configuration to show that it is no longer in use and that it will be removed.
##########
pulsar-common/src/main/java/org/apache/pulsar/policies/data/loadbalancer/LocalBrokerData.java:
##########
@@ -249,14 +249,21 @@ public String printResourceUsage() {
cpu.percentUsage(), memory.percentUsage(),
directMemory.percentUsage(), bandwidthIn.percentUsage(),
bandwidthOut.percentUsage());
}
-
+ @Deprecated
Review Comment:
Nit: what do you think about adding the `since = "3.0.0"` arg to the
`@Deprecated` annotation. I did that in a recent PR because it has the benefit
of making it clearer when we can remove it later. The history is clear in git,
but this lets a user skip a few steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
