michaeljmarshall commented on PR #20142: URL: https://github.com/apache/pulsar/pull/20142#issuecomment-1515111320
> > > #20068 is the correct implementation, I don't suggest we revert that. > > > > > > What is the purpose of changing the implementation of an abstraction that we are deprecating? > > Make sure this logic is correct. The logic has been there for a long time. It's likely extensions built on top of those methods already account for the short coming, which is why I said that solution could have unintended consequences. The problem described by #20066 is that the `Producer` and `Consumer` use the wrong method in the `AuthorizationService`. In my opinion, the right fix is to fix which method those classes use. > Maybe this affects the commit history, but I still suggest we keep https://github.com/apache/pulsar/pull/20068. That's a fair point. I will break this PR into two PRs to make the discussion clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
