michaeljmarshall commented on PR #20142:
URL: https://github.com/apache/pulsar/pull/20142#issuecomment-1515239829

   > If we allow for this change, I think #20068 is also safe, is it right?
   
   My concern for #20068 is not with the `AuthorizationProvider` implementation 
but rather with pulsar extensions running in the broker that call the 
`AuthorizationService#canProduceAsync` and 
`AuthorizationService#canConsumeAsync`. My primary argument is that there is no 
compelling reason to change the `AuthorizationService` implementation because 
there is already a "correct" alternative to use. As such, I want to leave those 
methods unchanged and to update the broker code to use the newer method to get 
the correct behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to