nodece commented on PR #20142: URL: https://github.com/apache/pulsar/pull/20142#issuecomment-1515224297
> > I rethought this PR, if the custom authorization provider didn't handle the `TopicOperation`, which introduces unintended consequences. > > @nodece - by that same logic, #20068 is invalid. The default for the provider is to fail, so it is a safe change: > > https://github.com/apache/pulsar/blob/efb251cec6ff7dd7a92bc8ff99e8b2fe04d1eb00/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationProvider.java#L344-L351 > > Further, the `allowTopicOperationAsync` has been used by `ServerCnx` for a while. I know we've been using `allowTopicOperationAsync` for a long time, but I'm still concerned about compatibility issues. If we allow for this change, I think #20068 is also safe, is it right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
