zzzming commented on code in PR #20498:
URL: https://github.com/apache/pulsar/pull/20498#discussion_r1223786598
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchSink.java:
##########
@@ -120,22 +123,21 @@ public void write(Record<GenericObject> record) throws
Exception {
switch (elasticSearchConfig.getNullValueAction()) {
case DELETE:
if (idAndDoc.getLeft() != null) {
+
metrics.incrementCounter(ElasticSearchMetrics.DELETE, 1);
Review Comment:
@asafm I changed to DELETE_ATTEMPT to count the number of attempts.
I'm having a problem to separate DELETE or index in the bulk operation. This
requires more code change. Can I do this in another PR? We do need a
delete_attempt count that helps to track if or how many delete documents
requests.
Would you help me to add the DELETE counter in another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
