asafm commented on code in PR #20498:
URL: https://github.com/apache/pulsar/pull/20498#discussion_r1225821021
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java:
##########
@@ -90,8 +82,8 @@ public void afterBulk(long executionId,
List<BulkProcessor.BulkOperationRequest>
record.fail();
checkForIrrecoverableError(record, result);
} else {
- incrementCounter(METRICS_TOTAL_SUCCESS, index);
record.ack();
+ metrics.incrementCounter(ElasticSearchMetrics.SUCCESS,
index);
Review Comment:
My point is changing the structure of the methods, not if it's by 1 or not :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
