asafm commented on code in PR #20498:
URL: https://github.com/apache/pulsar/pull/20498#discussion_r1228450115
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java:
##########
@@ -89,6 +94,7 @@ public void afterBulk(long executionId,
List<BulkProcessor.BulkOperationRequest>
for (BulkProcessor.BulkOperationRequest operation:
bulkOperationList) {
final Record record = operation.getPulsarRecord();
record.fail();
+ metrics.incrementCounter(ElasticSearchMetrics.FAILURE, 1);
Review Comment:
I don't get it.
You switched to 'event based' methodology in `ElasticSearchMetrics` for
`recordRecordIndexedSuccess()`, why not everywhere? This should be IMO
`metrics.recordRecordFailure()`
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java:
##########
@@ -89,6 +94,7 @@ public void afterBulk(long executionId,
List<BulkProcessor.BulkOperationRequest>
for (BulkProcessor.BulkOperationRequest operation:
bulkOperationList) {
final Record record = operation.getPulsarRecord();
record.fail();
+ metrics.incrementCounter(ElasticSearchMetrics.FAILURE, 1);
Review Comment:
How do you differentiate between retry failures to complete failures?
This method is called each time an attempt has failed.
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchMetrics.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.io.elasticsearch;
+
+import org.apache.pulsar.io.core.SinkContext;
+
+/*
+ * Metrics class for ElasticSearchSink
+ */
+public class ElasticSearchMetrics {
+
+ private SinkContext sinkContext;
+ // sink metrics
+ public static final String INCOMING = "_elasticsearch_incoming";
Review Comment:
why the leading underscore?
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchMetrics.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.io.elasticsearch;
+
+import org.apache.pulsar.io.core.SinkContext;
+
+/*
+ * Metrics class for ElasticSearchSink
+ */
+public class ElasticSearchMetrics {
+
+ private SinkContext sinkContext;
+ // sink metrics
+ public static final String INCOMING = "_elasticsearch_incoming";
+
+ // INCOMING = SUCCESS + FAILURE + SKIP + NULLVALUE_IGNORE
+ public static final String SUCCESS = "_elasticsearch_success";
+
+ // DELETE_ATTEMPT is an attempt to delete a document by id
+ // TODO: add delete success metrics, currently it's difficult to separate
delete and index from the bulk operations
+ public static final String DELETE_ATTEMPT = "elasticsearch_delete_attempt";
+
+ public static final String FAILURE = "elasticsearch_failure";
+ public static final String SKIP = "elasticsearch_skip";
+ public static final String WARN = "elasticsearch_warn";
+ public static final String MALFORMED_IGNORE =
"elasticsearch_malformed_ignore";
+ public static final String NULLVALUE_IGNORE =
"elasticsearch_nullvalue_ignore";
+
+ public ElasticSearchMetrics(SinkContext sinkContext) {
+ this.sinkContext = sinkContext;
+ }
+
+ public void incrementCounter(String counter, double value) {
+ this.sinkContext.recordMetric(counter, value);
Review Comment:
`this` is redundant
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchMetrics.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.io.elasticsearch;
+
+import org.apache.pulsar.io.core.SinkContext;
+
+/*
+ * Metrics class for ElasticSearchSink
+ */
+public class ElasticSearchMetrics {
+
+ private SinkContext sinkContext;
Review Comment:
place below static varibles
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchMetrics.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.io.elasticsearch;
+
+import org.apache.pulsar.io.core.SinkContext;
+
+/*
+ * Metrics class for ElasticSearchSink
+ */
+public class ElasticSearchMetrics {
+
+ private SinkContext sinkContext;
+ // sink metrics
+ public static final String INCOMING = "_elasticsearch_incoming";
+
+ // INCOMING = SUCCESS + FAILURE + SKIP + NULLVALUE_IGNORE
+ public static final String SUCCESS = "_elasticsearch_success";
Review Comment:
why the leading underscore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
