JooHyukKim commented on code in PR #20709:
URL: https://github.com/apache/pulsar/pull/20709#discussion_r1251779137
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBrokers.java:
##########
@@ -150,8 +150,8 @@ private class ShutDownBrokerGracefully extends CliCommand {
@Override
void run() throws Exception {
-
getAdmin().brokers().shutDownBrokerGracefully(maxConcurrentUnloadPerSec,
forcedTerminateTopic);
- System.out.println("Successfully trigger broker shutdown
gracefully");
+
getAdmin().brokers().shutDownBrokerGracefully(maxConcurrentUnloadPerSec,
forcedTerminateTopic).join();
+ System.out.println("Successfully broker shutdown gracefully");
Review Comment:
This stdout changed to reflect the new blocking behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]