JooHyukKim commented on code in PR #20709:
URL: https://github.com/apache/pulsar/pull/20709#discussion_r1252515007
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBrokers.java:
##########
@@ -150,8 +150,8 @@ private class ShutDownBrokerGracefully extends CliCommand {
@Override
void run() throws Exception {
-
getAdmin().brokers().shutDownBrokerGracefully(maxConcurrentUnloadPerSec,
forcedTerminateTopic);
- System.out.println("Successfully trigger broker shutdown
gracefully");
+
getAdmin().brokers().shutDownBrokerGracefully(maxConcurrentUnloadPerSec,
forcedTerminateTopic).join();
+ System.out.println("Successfully shutdown broker gracefully");
Review Comment:
I think `Cmd` classes are better off staying simple (not include sync/async)
and users are also better off controlling only through CLI params.
**EDITED** And in this case maybe we can add parameter like
`--wait-for-completion`, as suggested previously by @coderzc in
https://github.com/apache/pulsar/pull/20651#discussion_r1243567246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
